-
-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slate text editor causes a focus trap when tabbing #3679
Comments
I tried the Slate Rich Text demo, and I am able to tab in and out of the editor. Is there a plugin that takes over the TAB key while editing a list, like this one? |
@stevepiercy there are misunderstanding about what volto-slate is. You can't compare it with any other slate editor built, it's a completly unique implementation. Slate by itself only gives you a "contenteditable" control. There's no buttons, no parsing of HTML, almost nothing. The way a JSON is converted to "markup", how the DOM looks like inside that content editable, it's all volto-slate. @JeffersonBledsoe I think strictly speaking, there might be no accessibility problem, because the spec says
tab and arrows. It is possible to use the arrows to escape the slate (only if the next block is also a slate, though this is an unfortunate decision that maybe we can fix) |
@tiberiuichim I'll be honest, I didn't know you could use the arrow keys to navigate between the slate blocks! It makes sense if you think of the volto-slate system as a 'single' rich text editor rather than separate blocks. Still would be nice to have the tab key to navigate between blocks too. Although, It does bring into question when the tab should be used by the text editor (such as the list indentation that we currently have) and when it should be used by the block editor |
@JeffersonBledsoe I agree. One day I hope to have time to fix all the issues with slate. |
Describe the bug
While tabbing through a page in the blocks editor, reaching a 'slate' block causes the tab key to stop functioning. This is due to slate's ability to adjust the indent of lists using TAB or SHIFT+TAB, which DraftJS didn't seem to have out-the-box and so didn't cause an issue. If there is a way to exit the 'edit mode' of the slate editor, we need to advise the user of this behaviour to meet ATAG/ WCAG SC 2.1.2.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The next focusable element on the page is focused
The text was updated successfully, but these errors were encountered: