Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] - issues encountered working with small margins #3607

Closed
chriddyp opened this issue Mar 5, 2019 · 6 comments
Closed

[wip] - issues encountered working with small margins #3607

chriddyp opened this issue Mar 5, 2019 · 6 comments

Comments

@chriddyp
Copy link
Member

chriddyp commented Mar 5, 2019

This is a work-in-progress issue to contain screenshots and examples of issues that I'm running into with using extremely small margins with dash-design-kit.

In ddk, most graphs are inside other containers ("cards") and we're trying to keep the graph as large as possible within the container, ideally flush with the card. In order to do so, we set the margins really small and use automargin.

Most of the time this works great. There are some cases that I notice here and there where things get cut off. I'd like to collect those screenshots in this issue & then recategorize, isolate, create repro examples, and prioritize them later.

@chriddyp
Copy link
Member Author

chriddyp commented Mar 5, 2019

  • Rightmost label cut off
    image
    image

  • Rightmost hover label cut off
    image
    image

  • It'd be nice to be able to expand the graph's height rather than shrink it's bottom margin. In Dash apps, we frequently have variable or unspecified chart height

  • It'd be nice if I could specify a "minimum padding between label & axis title". with automargin, they end up looking a little too tight:
    image

@etpinard
Copy link
Contributor

etpinard commented Mar 5, 2019

  • Rightmost label cut off

That will be fixed in #3605 (assuming you have xaxis.automargin: true)

@etpinard
Copy link
Contributor

etpinard commented Mar 5, 2019

  • It'd be nice if I could specify a "minimum padding between label & axis title". with automargin, they end up looking a little too tight:

That one is related (but distinct, I think) to: #2575

@nicolaskruchten
Copy link
Contributor

OK, I've just created a batch of issues capturing the various cases and we'll work them during 1.51

@etpinard
Copy link
Contributor

Can we close this one?

All the issues pointed out here have been addressed (most of them released in v1.51.0) except for #4222

@chriddyp
Copy link
Member Author

🥇 🥇 🥇 Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants