Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new "npm run" target for building custom bundles #5484

Closed
nicolaskruchten opened this issue Feb 9, 2021 · 3 comments · Fixed by #5508
Closed

A new "npm run" target for building custom bundles #5484

nicolaskruchten opened this issue Feb 9, 2021 · 3 comments · Fixed by #5508
Assignees
Milestone

Comments

@nicolaskruchten
Copy link
Contributor

I'd like a straightforward set of instructions that a user can use to:

  1. Create my-custom-bundle.js based on something like lib/index-basic.js
  2. Run npm run build-custom-bundle my-custom-bundle.js and it would produce my-custom-bundle.min.js or whatever

This is needed so as to be able to provide clear instructions to Dash developers that want to make their own bundles :)

@archmoj archmoj added this to the NEXT milestone Feb 9, 2021
@nicolaskruchten
Copy link
Contributor Author

The custom-bundle build instructions should be documented in https://github.com/plotly/plotly.js/blob/master/BUILDING.md, as this is what I'm linking to from dash-docs for "custom-built bundle".

@archmoj
Copy link
Contributor

archmoj commented Feb 12, 2021

Right now scatter trace (puls cartesian subplots) are added to every bundle by default.
Do you think it should not be added by default for custom bundles?

@alexcjohnson
Copy link
Collaborator

If a bundle without scatter works, then yes. But I think it was put in core originally because otherwise something or other would break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants