Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New spike defaults for v2 #5619

Closed
nicolaskruchten opened this issue Apr 29, 2021 · 2 comments · Fixed by #5648
Closed

New spike defaults for v2 #5619

nicolaskruchten opened this issue Apr 29, 2021 · 2 comments · Fixed by #5648

Comments

@nicolaskruchten
Copy link
Contributor

I think the spikeline behaviour that we coerce today for x unified hovermode (in #4657) is better than the default behaviour... Should we change the compare defaults to be the same as the unified ones? i.e. *axis.spikesnap = 'hovered data' and spikedistance=-1 ?

@nicolaskruchten
Copy link
Contributor Author

so the justification for these new defaults is basically the intuition that by default, spike lines should attach to what's being hovered on. hovered data doesn't force this, it seems to act to prevent spikelines a non-hovered point because it's geometrically closer (allowing for a fallback to a more-distant hover-winning point I guess). To guarantee that the hovered point is always in range, we set spikedistance to -1.

@nicolaskruchten
Copy link
Contributor Author

Note that today, setting spikesnap='hovered data' forces spikes to true, which should no longer be the case when they're the default :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants