Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hover edge cases on period positioned points #5656

Closed
archmoj opened this issue May 13, 2021 · 1 comment
Closed

hover edge cases on period positioned points #5656

archmoj opened this issue May 13, 2021 · 1 comment
Labels
bug something broken

Comments

@archmoj
Copy link
Contributor

archmoj commented May 13, 2021

Clear improvement. There are three funny cases I want to point out, though we may choose not to do anything about them:

(1) the only place I can put the mouse and NOT get a label for any bar is slightly to the left of a first-of-month scatter point:
Screen Shot 2021-05-12 at 11 27 01 AM
If I put the mouse to the right of this point I do get a bar hover:
Screen Shot 2021-05-12 at 11 27 09 AM
This is presumably because the mouse is not over the range of the bar that matches the winning scatter point - so we include the previous bar in our original set of hovered points but then disqualify it because it's inconsistent with the scatter point.
This happens at all month boundaries in x mode, but if I switch to x unified mode, I see this behavior on the Dec/Jan boundary:
Screen Shot 2021-05-13 at 8 57 09 AM
but not on the Jan/Feb boundary, there I always get the Feb bar no matter where my mouse is:
Screen Shot 2021-05-13 at 8 57 24 AM

(2) When I zoom in enough, there are gaps between scatter points so that none of them are hovered, and only a bar is shown in the hover info. But if I set xperiod to 5 days on the scatter trace, I would have expected that no matter how much I zoom in there would be a winning scatter point, because I'm always over the period of one of them. That doesn't happen, in either x or x unified hovermode. In both modes there's still a gap where I only see the bar's hover.

(3) Except in a very narrow set of conditions, when no matter which scatter gap my mouse is in, the middle scatter point is included in hover data with the bar. I only see this with an xperiod on the scatter and in x hovermode - not with instant-positioned scatter points and not with x unified, and at least in the codepen given there's a very narrow zoom range where this happens, immediately after gaps in the scatter have opened up but before they get too big. Here my mouse is on about Jan 27:
Screen Shot 2021-05-13 at 8 48 02 AM
(This third point may become moot if we choose to address the second point)

Originally posted by @alexcjohnson in #5618 (comment)

@alexcjohnson
Copy link
Collaborator

Closed by #5683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

2 participants