Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x, y and z error bars should have different attributes #621

Closed
etpinard opened this issue Jun 9, 2016 · 0 comments
Closed

x, y and z error bars should have different attributes #621

etpinard opened this issue Jun 9, 2016 · 0 comments
Assignees
Labels
bug something broken

Comments

@etpinard
Copy link
Contributor

etpinard commented Jun 9, 2016

At the moment, all error bar containers (i.e. error_x, error_y and error_z) are linked to the same attribute declarations found in src/components/errorbars/attributes.js.

But, the error bar attributes contains container-specific attributes, namely, copy_ystyle and copy_zstyle (see here). These attribute should only be shown in the relevant containers.

The solution would be make the src/components/errorbars/attributes.js export a function that return attributes specific to the container e.g.:

// in traces/scatter/attributes.js

var errorBarAttributes = require('../../components/errorbars/attributes');

module.exports = {
  // ...

  error_x: errorBarAttributes('x'),
  error_y: errorBarAttributes('y')
};

similar to what PR #609 put forward for colorscale attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

1 participant