Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log scale validation too strict againts null values #1100

Closed
tflanitzer opened this issue Aug 13, 2020 · 3 comments
Closed

Log scale validation too strict againts null values #1100

tflanitzer opened this issue Aug 13, 2020 · 3 comments

Comments

@tflanitzer
Copy link
Contributor

When using a line with a log scale on data that has null or undefined values, an exception is thrown ("a log scale domain must be strictly-positive or strictly-negative"). However, when the check is removed (packages/scales/src/logScale.js:19), the line displays fine with gaps, as expected. I have created PR #1099 with a possible fix.

To Reproduce
To reproduce the validation error, just use a null value in a data set with a log scale. See this codesandbox.

Expected behavior
Like with linear scales, data points without value (null or undefined) should just not be displayed and the line should be separated.

Screenshots
Here is a screenshot proving that it works with the validation disabled.
logscalewnull

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Chrome
  • Version 84
@stale
Copy link

stale bot commented Nov 11, 2020

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Nov 11, 2020
@tflanitzer
Copy link
Contributor Author

Still an issue and really easy to resolve, see mentioned pr

@stale stale bot removed the stale label Nov 11, 2020
@plouc
Copy link
Owner

plouc commented Nov 11, 2020

Solved by #1099, thank you @tflanitzer for the PR!

@plouc plouc closed this as completed Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants