Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar Chart - renderToStaticMarkup not rendering properly #2297

Closed
mrkirchner opened this issue Apr 23, 2023 · 5 comments
Closed

Bar Chart - renderToStaticMarkup not rendering properly #2297

mrkirchner opened this issue Apr 23, 2023 · 5 comments
Labels
animation 📊 bar @nivo/bar package

Comments

@mrkirchner
Copy link

Describe/explain the bug
When rendering a barchart with renderToStaticMarkup the bars will not render. At one point there was this bug but was closed #1778.

Even a pr was added but never merged due to package changes.
#1712

To Reproduce
Steps to reproduce the behavior:
https://codesandbox.io/s/bar-staticmarkup-x6vzv?file=/src/App.js

  1. Render a Bar chart using renderToStaticMarkup to see no bars.

Expected behavior
Bars render properly

Screenshots
Screenshot 2023-04-23 at 3 13 13 PM

Desktop (please complete the following information):

  • OS: OSX
  • Browser Chrome/Firefox/Safari
  • Version 80
@mrkirchner
Copy link
Author

@plouc does Nivo have anyone fixing issues? This issue also seems related #2368

@stale stale bot added the stale label Oct 15, 2023
@mrkirchner
Copy link
Author

Bump?

@mrkirchner
Copy link
Author

@plouc or @shoito any word on this ? It prevents using bar on server side. Original pr was one liner but package was moved.

@stale stale bot removed the stale label Nov 7, 2023
@OleksandrRakovets
Copy link
Contributor

Sorry it took so long 😮‍💨

Been using a custom build with this change in production for over a year w/o any issues.

Hope it'll get merged this time 🤞

Repository owner deleted a comment from stale bot Nov 16, 2023
@plouc plouc added 📊 bar @nivo/bar package animation labels Nov 16, 2023
@plouc
Copy link
Owner

plouc commented Nov 16, 2023

This issue should have been solved by #2464.

@OleksandrRakovets, thank you!

@plouc plouc closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
animation 📊 bar @nivo/bar package
Projects
None yet
Development

No branches or pull requests

3 participants