-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 19 Support #2618
Comments
Adding support for React 19 might be a lot of work, it's also still unclear, looking at the migration guide, if I could still support older React versions with the same @nivo version. The 19 still being a RC at the moment, I think it's not really pressing, and I'd probably need to upgrade gatsby, storybook... as well, which seems like a huge project. Finally, I was migrating tests from It will take time to get there and this should be split in sub-projects, I don't have the bandwidth to handle everything at once. |
Will follow this thread, we are a company that are about to replace our current chart solution. I understand that time estimation is super hard, but do you think this will take years or months after React 19 release? |
React has an issue where they link some libraries and respective PRs how those libraries upgraded to react 19. imho, the starting point would be to run various provided by React 19 codemods which should do the heavy lifting:
|
@o-alexandrov, thank you for sharing, this could help. |
Latest major version of Next.js (version 15) uses React 19 RC, so it's not going to be possible to use Nivo with it |
Man.. this is no good.. |
I was upgrading to Next 15 and by effect React 19, and ended up being blocked by this issue as well. |
I'm about to use Nivo but also like to upgrade to Next 15 / React 19 the next few weeks. Is there a work-around for the moment? |
And React 19 is now stable... |
I get a TypeScript error after upgrading React to 19. Is anyone else experiencing the same issue? |
I solved my issue by adding it to the global.d.ts file.
The reason is; https://react.dev/blog/2024/04/25/react-19-upgrade-guide#the-jsx-namespace-in-typescript |
I have updated my project to NextJS 15 and React 19. Using overrides and all seems to work just fine!
|
Hey 👋 I'd like to support with enabling React 19 support in the project. How can we track the todos left to reach it? |
I'm also interested in using Nivo with Next 15+ / React 19+. Subscribed to this thread. |
I switched to @visx/[email protected] for now. It has proper support for React 19. |
As someone reported it worked with overrides, I could increase the range of allowed version for now. |
Are tooltips working for you folks? They do not seem to work for me (default or custom) migrating to react 19, nextjs 15 and nivo 0.88 (coming from 0.87) without throwing any error in Sunburst, Line and CirclePacking |
Yes, it works for me, I use custom and regular tooltips. I also use custom layers on the ResponsivePie chart. You can see above the charts I'm using and versions. |
Right, I was able to test it in isolated environments and the issue seems to be regarding nextjs 15. Can’t figure out exactly what is happening though. |
Hmm strange.. 🤔. Sry I cant help you with this, but I do nothing special or unusual. Just use them as in the docs. An example:
|
@nass600 I also have issues with tooltips not rendering. I do have the crosshairs render and follow the mouse cursor, but the tooltips are completely missing. |
@nass600 I was able to get tooltips working! I had to simply add the
|
Is your feature request related to a problem? Please describe.
@nivo/core
(and possibly other packages) have a strict React dependency range that restricts React 19--legacy-peer-deps
flag or--force
for every installation which is not ideal.Describe the solution you'd like
The text was updated successfully, but these errors were encountered: