Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object implementations for all ELSE objects #174

Closed
19 tasks done
timothyschoen opened this issue Aug 26, 2022 · 15 comments
Closed
19 tasks done

Add object implementations for all ELSE objects #174

timothyschoen opened this issue Aug 26, 2022 · 15 comments
Assignees

Comments

@timothyschoen
Copy link
Collaborator

timothyschoen commented Aug 26, 2022

The ones that are missing are:

  • [button] (0.6.1)
  • [oscope~]. (0.6.2)
  • [function] (0.6.2)
  • [bicoeff] (0.7.0)
  • [colors] (v0.7.1)
  • [messbox] (0.7.0)
  • [note] (0.7.1)
  • [click] (0.7.1)
  • [pic] (0.7.1)
  • [properties] (0.8.0)
  • [keycode] (0.8.1)
  • [openfile] (0.8.1)
  • [canvas.bounds] (0.8.1)
  • [cyclone/mousestate] (0.8.1) (this one also appears to be pretty broken in pd-vanilla)

Need to be checked again:

  • [canvas.active] (0.6.2)
  • [canvas.mouse] (0.6.2)
  • [canvas.vis] (0.6.2)
  • [canvas.zoom] (0.6.2)
  • [canvas.edit] (0.6.2)

Numbers indicate the versions that I'm planning to implement them at.

@timothyschoen timothyschoen changed the title Add object implenentations for all ELSE objects Add object implementations for all ELSE objects Jan 14, 2023
@porres
Copy link
Collaborator

porres commented Jan 14, 2023

yeah, I was just about to say canvas.mouse is not working well

@timothyschoen
Copy link
Collaborator Author

What's wrong with [canvas.mouse]? I think the y-axis is also inverted there?

@porres
Copy link
Collaborator

porres commented Jan 15, 2023

seems weirder than that, but yeah, output is wrong and you had it in your list already

@tomara-x
Copy link
Contributor

[canvas.bounds] also doesn't work

@porres
Copy link
Collaborator

porres commented Mar 3, 2023

ok, add else/click to the list :) but note that also click functions from other objects are not working, see #635

@porres
Copy link
Collaborator

porres commented Mar 3, 2023

add also [else/properties] to the list

@porres
Copy link
Collaborator

porres commented Mar 3, 2023

canvas.setname doesn't seem to be working either and seems crazy but [namecanvas] isn't either, which will force me to open a new issue.

@porres
Copy link
Collaborator

porres commented Mar 3, 2023

at this point I would go ahead and list all "canvas.*" objects into the list to check

@porres
Copy link
Collaborator

porres commented Mar 5, 2023

the 'pick' message to [colors] is not working (so is not the clicking)

@porres
Copy link
Collaborator

porres commented Mar 6, 2023

add [keycode] to the list :)

@jyg
Copy link
Contributor

jyg commented Mar 22, 2023

add also else/canvas.bounds and cyclone/mousestate

@timothyschoen timothyschoen moved this to Todo in v0.8.0 May 22, 2023
@timothyschoen timothyschoen moved this from Todo to In Progress in v0.8.0 May 22, 2023
@timothyschoen timothyschoen self-assigned this May 22, 2023
@timothyschoen timothyschoen moved this from In Progress to Done in v0.8.0 Aug 17, 2023
@porres
Copy link
Collaborator

porres commented Aug 20, 2023

openfile doesn't seems to work with the -h flag yet, is it actuallt ready or not"

@timothyschoen timothyschoen moved this to Todo in v0.8.1 Oct 13, 2023
@timothyschoen timothyschoen moved this from Todo to In Progress in v0.8.1 Oct 13, 2023
@timothyschoen
Copy link
Collaborator Author

Added keycode implementation now, looks like we're basically done!

I'll check keycode some more, then hopefully close this issue (meaning pretty much complete ELSE support!)

@timothyschoen
Copy link
Collaborator Author

I've tested keycode on every OS, seems to work perfectly! Let's goooo

@github-project-automation github-project-automation bot moved this from In Progress to Done in v0.8.1 Oct 14, 2023
@porres
Copy link
Collaborator

porres commented Oct 14, 2023

Does [cyclone/mousestate] really appear to be pretty broken in pd-vanilla?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Status: Done
Development

No branches or pull requests

4 participants