Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: logo optimization and adding alt #2784

Merged
merged 4 commits into from
Oct 12, 2024
Merged

docs: logo optimization and adding alt #2784

merged 4 commits into from
Oct 12, 2024

Conversation

Amyssyko
Copy link
Contributor

The JPG image has been replaced with an AVIF version, which offers better compression and faster loading times, AVIF (which is supported by 92.64% of browsers worldwide according to caniuse). This optimizes page performance without compromising compatibility or image quality.

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 3:21am

Copy link

codesandbox-ci bot commented Oct 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leave the image file unchanged for now. ALT seems good.

@Amyssyko
Copy link
Contributor Author

I understand the request to keep the current image. To implement the alt text and also improve performance with AVIF, we could use the following structure:

<div class="flex justify-center mb-4">
  <picture>
    <source srcset="../bear.avif" type="image/avif" />
    <img src="../bear.jpg" alt="Logo Zustand" />
  </picture>
</div>

Keep the image used as a fallback and optimize it

@dai-shi
Copy link
Member

dai-shi commented Oct 12, 2024

I understand your suggestion, thanks. But, let's just leave it.

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants