Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicate Edit, Order/Arrange/Move, and Delete as done in QuickLinks WebPart #2229

Open
brianpmccullough opened this issue Jan 29, 2022 · 5 comments
Labels
Help wanted 🪧 type:sample-request Indicates a request for a new sample

Comments

@brianpmccullough
Copy link

Sample description

Replicate Edit, Order/Arrange/Move, and Delete as done in QuickLinks WebPart including accessibility behaviors of Left/Right arrows for selection of card and Ctrl + Left/Right Arrows for movement of card.

image001

SPFx version

1.13.1

Are you willing to help?

Yes

@brianpmccullough brianpmccullough added Help wanted 🪧 type:sample-request Indicates a request for a new sample labels Jan 29, 2022
@ghost
Copy link

ghost commented Jan 29, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jan 29, 2022
@PooLP
Copy link
Contributor

PooLP commented Jan 31, 2022

i have this => https://github.com/PooLP/spfx-react-drag-drop-inline-edit-sample
it's a POC to reproduce the UX of quick links, but i don't have accessibility behaviors.
i have make this for test "getDetailsPaneConfiguration" to open another property pane, but it's not documented by MS.

@Tanddant
Copy link
Contributor

Tanddant commented Mar 5, 2023

I hadn't seen @PooLP already answered your question, but I've submitted a PR that mostly solves this one - you can freely update it to support keyboard shoutcuts, for inspiration take a look under keycodes in the react-sortable-hoc docs

Instead of using the getDetailsPaneConfiguration I'm forcing a rerender of the propertypane, I really couldn't find a pretty way that's documented to do this, yet another reason MS should open source some of their webparts

@PooLP
Copy link
Contributor

PooLP commented Mar 6, 2023

I think we should use dnd kit for that, much more complete and maintained.
For MS and real open Source for SPFx, good luck :D

@Tanddant
Copy link
Contributor

Tanddant commented Mar 6, 2023

DnD kit is probably the better way to go, I just went for something I knew to be working 😊

Well if we don't push for it, it won't happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help wanted 🪧 type:sample-request Indicates a request for a new sample
Projects
None yet
Development

No branches or pull requests

4 participants