Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CARGO_HOME envvar in Makevars #29

Open
yutannihilation opened this issue Jan 17, 2023 · 3 comments · Fixed by #292
Open

Set CARGO_HOME envvar in Makevars #29

yutannihilation opened this issue Jan 17, 2023 · 3 comments · Fixed by #292
Labels
installation About installation or setup

Comments

@yutannihilation
Copy link
Contributor

yutannihilation commented Jan 17, 2023

This is mandatory if you want to release this package on CRAN eventually. If not, you don't need to care.

https://github.com/r-rust/faq#how-to-avoid-writing-in-home

@sorhawell
Copy link
Collaborator

When moving cargo_home inside the package `R CMD check-warning like below may pop up depending on what dependencies.

I think it can be solved with some extra spring cleaning after cargo build, but before linking and R build finalizes.

I have been tinkering with builds and makevars for non stop 3 days.
To avoid madness, I will wait a week or so finalizing this ^^

* checking package subdirectories ... WARNING
Warning: Found the following directories with names of version control directories:
  ./src/.cargo/git/checkouts/arrow2-945af624853845da/baa2618/.git
  ./src/.cargo/git/checkouts/arrow2-945af624853845da/baa2618/testing/arrow-testing/.git
  ./src/.cargo/git/checkouts/arrow2-945af624853845da/baa2618/testing/parquet-testing/.git
  ./src/.cargo/git/checkouts/extendr-569c02e1a164cdf5/f511254/.git
  ./src/.cargo/git/checkouts/jsonpath-3ee2ec25574f7416/24eaf0b/.git
  ./src/.cargo/git/checkouts/polars-b0d90607192fd414/a7d38dd/.git
  ./src/.cargo/registry/index/github.com-1ecc6299db9ec823/.git

@sorhawell
Copy link
Collaborator

Reminder to myself
@eitsupi noticed I should use CURDIR instead of PWD in makefiles
#30 (comment)

@eitsupi
Copy link
Collaborator

eitsupi commented Aug 3, 2023

Reopened by #340

@eitsupi eitsupi added the installation About installation or setup label Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation About installation or setup
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants