Add method to handle focus shifting when selected pill is clicked #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldavidson45
requested review from
jackkoppa,
RED143,
ivan-shtyrlyaev-nitka,
EvanSanderson,
guirreri and
hungsu
hungsu
reviewed
Oct 30, 2020
src/SelectMulti.vue
Outdated
| removeOptionAndHandleFocusShift(index: number) { | ||
| this.removeOption(index) | ||
| this.$nextTick(() => { | ||
| if (this.selectedOptions.length === 0) { |
There was a problem hiding this comment.
Super tiny but looks like this should be indented one more level since it's inside a block?
There was a problem hiding this comment.
Thanks for catching that @hungsu ! I'll fix that before merging
There was a problem hiding this comment.
I wonder if people would object to our eslint rules being moved to a public repo? Then we could use them here...
hungsu
approved these changes
Oct 30, 2020
jackkoppa
reviewed
Nov 6, 2020
| class="selected-option-pill" | ||
| :disabled="disabled" | ||
| type="button" | ||
| :aria-describedby="`${htmlId}-selected-option-pills`" | ||
| @click="removeOption(index)" | ||
| @click="removeOptionAndHandleFocusShift(index)" |
jackkoppa
approved these changes
Nov 6, 2020
ldavidson45
force-pushed
the
liz/focus-shift
branch
from
b02c6d2 to
a3c2b41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We know that NVDA does not announce the element focused in some instances (detailed here nvaccess/nvda#5825 (comment))
Here is the NVDA/Firefox screenreader & focus shifting behavior:
And Voiceover/Safari:
