Signing and verifying a message using ECDSA sometimes fails

[rjwebb]

• I'm submitting a ...

  • Bug report
  • Feature request
  • Support request
  • Other

• What is the current behavior and expected behavior?

Expected behaviour: I should be able to generate a KeyringPair that signs messages using the ECDSA algorithm and verify the signatures against the message + the KeyringPair's public key

Current behaviour: This works most of the time, approx 99/100 times, but sometimes the verification fails.

• What is the motivation for changing the behavior?

I'm working on a project that relies on being able to sign and verify data from the KeyringPair or from Polkadot wallets so I want to be able to rely on this functionality.

• Please tell us about your environment:

I'm using @polkadot/keyring, @polkadot/util and @polkadot/util-crypto at the latest version as of writing (12.6.1).

I've created a minimal repository here that reproduces the bug: https://github.com/rjwebb/polkadot-ecdsa-bug-reproduction

• Version: 12.6.1

• Environment: Node v18.17.1

  • Node.js
  • Browser
  • Other (limited support for other environments)

• Language:

  • JavaScript
  • TypeScript (include tsc --version) 5.2.2
  • Other

[TarikGul]

Thanks for the reproduction, I was able to reproduce it. Added to the project board as High, and putting a Help wanted tag on it to hopefully garner a little bit of attention. If bandwidth frees up I will investigate this further.