Remove support for encrypt/decrypt on keypair #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 14, 2023
polkadot-js-bot
approved these changes
Mar 14, 2023
|
We were specifically using encryptMessage & decryptMessage. @jacogr Would you be able to revert your change and bring these functions back onto the keyring object? |
4 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not something that can be reliably done (based on the approach followed here) with converting keys.
With an offline secret exchange it is possible, however since we want a one-stop solution it is not something that atm I specifically have appetite for. With all that said - if there are other interesting solutions and PRs do appear that make it an all-in-one, we can certainly look at bringing this back.
(This PR means I'm closing #1320 & #1331)
Closes #1314