-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encryption/Decryption Feature #928
Comments
At this time, I cannot get things work with sr22519 keypair. Another solution (and easiest) could be to do symmetric encryption (let say AES) using a derived key from the account secret key. Does it make sense ? |
I like the functionality, it is a nice addition. However, as mentioned if it doesn't work at the base, it is a no-go area. Fixes welcome at that level. |
Glad to hear ! 🙏 At this time, I see 3 options:
I will do some experiments with the second option... Any thoughts on this is welcome ! Edit: Work in progress at polkadot-js/common#1331 |
Thanks for working on this. I'm trudging my way through implementation on this and ran into the same issue which it looks like @RoyTimes has workaround out to fix. When thinking about this decrypt UI dialogue - can this UI dialog be optional? and/or can the decrypt ui be enabled once for multiple decrypts? |
Thanks for your comment.
I think it's possible, but is it desirable ? I don't have a strong opinion, but we could make it possible through an option, like |
Since the unlocking in the backend is the same, the "remember for 15 minutes" would apply here as well. Can't really and shouldn't really make it different, but agree that it could add value. (The next 15 is from the last operation, so if you decrypt at least 1 message every 15 minutes, it is basically indefinitely) |
Thanks for your reply @jacogr ! |
This issue has been open for 21 days with no activity and is not labelled as an enhancement. It will be closed in 7 days. |
Hi ! |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query. |
Hi !
Now that the encryption/decryption feature has been added to Polkadot Common JS library, it could be great to add this feature to the extension :)
This feature has already been requested (#691) but rejected as the underlying feature was not available.
I started to work on this for my personal needs, and got something working for the decryption part :
You can have a look at this fork (Disclaimer: quick and dirty hackathon code ;) )
It seems that @RoyTimes planned to work on this but I don't know where he is.
It would be my pleasure to work on this feature if you think it's worth it.
Feel free to share your thoughts, thanks !
The text was updated successfully, but these errors were encountered: