From adbe65457ec69863c111b64da7baddb42feccd9c Mon Sep 17 00:00:00 2001
From: Casey Rodarmor <casey@rodarmor.com>
Date: Wed, 18 Jan 2023 10:38:16 -0800
Subject: [PATCH] Bail if reveal transaction is too large (#1272)

---
 src/subcommand/wallet/inscribe.rs | 38 +++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/src/subcommand/wallet/inscribe.rs b/src/subcommand/wallet/inscribe.rs
index 2940706bda..1b08036527 100644
--- a/src/subcommand/wallet/inscribe.rs
+++ b/src/subcommand/wallet/inscribe.rs
@@ -2,6 +2,7 @@ use {
   super::*,
   bitcoin::{
     blockdata::{opcodes, script},
+    policy::MAX_STANDARD_TX_WEIGHT,
     schnorr::{TapTweak, TweakedKeyPair, TweakedPublicKey, UntweakedKeyPair},
     secp256k1::{
       self, constants::SCHNORR_SIGNATURE_SIZE, rand, schnorr::Signature, Secp256k1, XOnlyPublicKey,
@@ -276,6 +277,14 @@ impl Inscribe {
       commit_tx_address
     );
 
+    let reveal_weight = reveal_tx.weight();
+
+    if reveal_weight > MAX_STANDARD_TX_WEIGHT.try_into().unwrap() {
+      bail!(
+        "reveal transaction weight greater than {MAX_STANDARD_TX_WEIGHT} (MAX_STANDARD_TX_WEIGHT): {reveal_weight}"
+      );
+    }
+
     Ok((unsigned_commit_tx, reveal_tx, recovery_key_pair))
   }
 
@@ -513,4 +522,33 @@ mod tests {
       20_000 - fee - (20_000 - commit_tx.output[0].value),
     );
   }
+
+  #[test]
+  fn inscribe_over_max_standard_tx_weight() {
+    let utxos = vec![(outpoint(1), Amount::from_sat(50 * COIN_VALUE))];
+
+    let inscription = inscription("text/plain", [0; MAX_STANDARD_TX_WEIGHT as usize]);
+    let satpoint = None;
+    let commit_address = change(0);
+    let reveal_address = recipient();
+
+    let error = Inscribe::create_inscription_transactions(
+      satpoint,
+      inscription,
+      BTreeMap::new(),
+      Network::Bitcoin,
+      utxos.into_iter().collect(),
+      vec![commit_address, change(1)],
+      reveal_address,
+      FeeRate::try_from(1.0).unwrap(),
+    )
+    .unwrap_err()
+    .to_string();
+
+    assert!(
+      error.contains(&format!("reveal transaction weight greater than {MAX_STANDARD_TX_WEIGHT} (MAX_STANDARD_TX_WEIGHT): 402799")),
+      "{}",
+      error
+    );
+  }
 }