[server] [merged] Return HTTP errors in JSON format if Accept: contains application/json #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelmer
reviewed
May 28, 2019
|
This seems reasonable; one comment inline about Accept header parsing. |
jelmer
changed the title
|
@sundbry would you mind rebasing and addressing the comment by jelmer? |
|
@sundbry this is a nice improvement. Please see inline comments and implement those slight tweaks when you find the time. |
|
On Wed, Feb 23, 2022 at 12:51:12PM -0800, ix5 wrote:
@ix5 commented on this pull request.
> @@ -81,6 +81,11 @@
logger = logging.getLogger("isso")
+def error_handler(env, request, error):
+ if "application/json" in request.headers["Accept"]:
I see. This would be an example header:
`Accept: text/html, application/xhtml+xml, application/xml;q=0.9, image/webp, */*;q=0.8`
Perhaps create iterable by splitting on comma (+strip whitespace yada yada), filter out everything except `text/html` and `application/json`, then return based on first match, else text-only response.
I was hoping there was something in one of the libraries we're using that you could just reuse. Reimplementing that logic is doable but tricky - you'd also need to handle priorities and wildcards.
Jelmer
|
ix5
added
server
ix5
changed the title
ix5
added a commit
that referenced
this pull request
May 25, 2022
[server] Return HTTP errors in JSON format if Accept: contains application/json
|
Merged, though I had to manually override some changes. (You sadly disabled push access for maintainers to your branch, @sundbry) |
ix5
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Merged as bf701c8
Addresses issue #487 by returning JSON format error messages when in the request Accept: headers.
This does not affect existing client behavior as far as I can tell, from testing the /demo/index.html, it does not send Accept: application/json in the headers.