Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server] db: comments: Constrain parent of new comments #885

Merged
merged 3 commits into from
Jun 5, 2022
Merged

[server] db: comments: Constrain parent of new comments #885

merged 3 commits into from
Jun 5, 2022

Conversation

ix5
Copy link
Member

@ix5 ix5 commented May 25, 2022 •
edited
Loading

Checklist

  • All new and existing tests are passing
  • (If adding features:) I have added tests to cover my changes
  • (If docs changes needed:) I have updated the documentation accordingly.
  • I have added an entry to CHANGES.rst because this is a user-facing change or an important bugfix
  • I have written proper commit message(s)

What changes does this Pull Request introduce?

  • db: comments: Constrain parent of new comments
  • tests: Add test for invalid comment parents

Why is this necessary?

Fixes #765

@ix5 ix5 added server (Python) server code bug labels May 25, 2022
@ix5 ix5 added this to the 0.13 milestone May 25, 2022
@ix5 ix5 mentioned this pull request May 25, 2022
Closed
@ix5 ix5 force-pushed the db-constraint-parent-tid branch from 8146d4c to 9549a43 Compare May 27, 2022 04:59
@ix5
Copy link
Member Author

ix5 commented Jun 5, 2022

Maybe this could be solved more elegantly in the future, but looks fine for now.

@ix5 ix5 merged commit b5b3e82 into isso-comments:master Jun 5, 2022
@ix5 ix5 deleted the db-constraint-parent-tid branch June 5, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug server (Python) server code
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.

[server] 500 Error with wrong parent
1 participant
@ix5