Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to post comments with umlaut domains in the website field #951

Closed
3 tasks done
schneidr opened this issue Apr 17, 2023 · 1 comment
Closed
3 tasks done

Unable to post comments with umlaut domains in the website field #951

schneidr opened this issue Apr 17, 2023 · 1 comment
Labels
bug needs-contributor Someone needs to implement this. Help wanted! needs-decision Architectural/Behavioral decision by maintainers needed server (Python) server code
Milestone
0.13.1

Comments

@schneidr
Copy link
Contributor

schneidr commented Apr 17, 2023 •
edited
Loading

Checklist

  • I am running the latest version. Installing Isso from GitHub from the master branch does not fix my issue
  • I have checked the troubleshooting guide
  • I have searched the open issues, but my issue has not already been reported
  • Note: I was unable to get the master branch running, but I compared the source code and the relevant parts didn't change

What is not working?

Posting a comment with an umlaut in the website (IDN) fails. The developer console of the browser shows the error from the server:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">
<title>400 Bad Request</title>
<h1>Bad Request</h1>
<p>Website not Django-conform</p>

I tracked it down to the regex definition in views/comments.py, which only allows [A-Z0-9-].

Using the validator module instead looks promising, otherwise the domain probably needs to be converted to IDN notation before the check.

How can one reproduce this issue?

Enter an IDN domain with an umlaut in any installation, it also fails in the demo in the isso website, and check the developer console.
@ix5 ix5 added server (Python) server code needs-contributor Someone needs to implement this. Help wanted! needs-decision Architectural/Behavioral decision by maintainers needed bug labels Apr 17, 2023
@ix5 ix5 added this to the 0.14 milestone Apr 17, 2023
@schneidr schneidr mentioned this issue Apr 18, 2023
Merged
4 tasks
@ix5
Copy link
Member

ix5 commented Jan 20, 2024

Should be resolved by #952
Otherwise, please comment if this should still be an ongoing issue.

@ix5 ix5 closed this as completed Jan 20, 2024
@ix5 ix5 modified the milestones: 0.14, 0.13.1 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs-contributor Someone needs to implement this. Help wanted! needs-decision Architectural/Behavioral decision by maintainers needed server (Python) server code
Projects
None yet
Milestone
0.13.1
Development

No branches or pull requests
2 participants
@schneidr @ix5