Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viewer: clicking on open content in editor tab should focus to editor tab if already open #5527

Open
midleman opened this issue Nov 26, 2024 · 0 comments
Assignees
Labels
area: viewer Issues related to Viewer category. bug Something isn't working

Comments

@midleman
Copy link
Contributor

System details:

Positron and OS details:

Positron Version: 2024.12.0 (Universal) build 80
Code - OSS Version: 1.93.0
Commit: c3c4896
Date: 2024-11-26T02:46:47.938Z
Electron: 30.4.0
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Darwin arm64 23.6.0

Describe the issue:

The Viewer should behave similarly to the Data Explorer and Plots when they are opened in the editor area. Repeatedly clicking on it should focus the existing tab rather than opening a new one.

Steps to reproduce the issue:

  1. Right-click on any HTML and select Open in Viewer.
  2. Verify that the Viewer displays as expected — PASS.
  3. Click the Open the Content in the Editor button.
  4. Verify that the content opens in the editor — PASS.
  5. Click the Open the Content in the Editor button again.
  6. Verify that another editor tab does NOT open — FAIL.

Expected behavior:

If the content is already displayed in the editor, clicking the button should switch focus to the existing tab instead of opening a new one.

@juliasilge juliasilge added the area: viewer Issues related to Viewer category. label Nov 26, 2024
@juliasilge juliasilge added this to the 2025.01.0 Pre-Release milestone Nov 26, 2024
@juliasilge juliasilge added the bug Something isn't working label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: viewer Issues related to Viewer category. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants