Fix error propagation for supervisor #5503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the error message for some fairly generic-looking errors like "HTTP request failed" that are occasionally reported when kernels fail to start.
The change may look like a no-op, but it isn't; because of the way JS async exception handling works, we need to explicitly
awaitthe async expression in order to catch exceptions. What was happening here was that exceptions thrown fromtryStart()in this codepath were not getting handled in thetry/catchblock (despite being thrown from inside the block). Instead, they were thrown directly bystart(), with the result that none of the code intended to marshal API errors to the UI layer was running to summarize the error.Partial backport of #5490 for the 2024.11.1 branch.