Add fetchAll method
#207
Merged
Add fetchAll method
#207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
fetchAllpublic method.fetchAlljust callsfetchbut will drain the async generator and return an array of results.It appears users commonly hit the issue with this library where they are unable to make IMAP commands while using
fetchAllnot realizing that it causes a deadlock. Without the library automatically detecting misusage like this, time will be wasted by developers while they learn about this edge case. Unfortunately a single comment in some example code for the documentation of the.fetchfunction is not enough.Having a
.fetchAllmethod provides an easy to use interface for the library which will help new users and increase library adoption.Related Issues:
#206
#159
#130
#110