-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.0.0 broke comments on nested elements #164
Comments
@Ulyanov-programmer can you look and fix? |
I'll get on it as soon as possible. It will be necessary to add similar situations to the tests... |
It seems that comments cause a lot of problems: .md {
color: red;
& > * {
margin-bottom: 12px;
}
/* table */
table {}
} generated: .md {
color: red;
}
.md .md * {
margin-bottom: 12px;
}
/* table */
table {
} |
@Plumbiu the comment was moved correctly. Where is the problem? |
Nesting does not work) |
Seems like I missed that there was a problem with selectors. Can you send PR because it is regression? |
|
The fix was released in 7.0.2. |
The change in #163 naively that was included in 7.0.0 expects the node contents to be something that can be included in a regex, but the problem is that both CSS and Regex share some syntax elements, including
[]
used for attribute selector and character classes, respectively.This means that a simple code like this:
will now fail with
This is due to the fact that
[data-roots-all]
is not treated as a literal, but rather a character class - and thuss-a
class trips it up.The text was updated successfully, but these errors were encountered: