-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prefetch on queries #103
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for funny-banoffee-0afb46 canceled.
|
@posva Hey! I think it's good to go for a first review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it's looking good!
I still need to look at this from the practical perspective of using it with data loaders before going further so it might take a few weeks to merge
@pinia/colada
@pinia/colada-nuxt
@pinia/colada-plugin-auto-invalidate
@pinia/colada-plugin-debug
@pinia/colada-plugin-delay
@pinia/colada-plugin-cache-persister
@pinia/colada-plugin-retry
commit: |
Co-authored-by: Eduardo San Martin Morote <[email protected]>
Co-authored-by: Eduardo San Martin Morote <[email protected]>
Co-authored-by: Eduardo San Martin Morote <[email protected]>
@posva I think everything is fixed! |
Hey. This is a draft PR heavily inspired on: https://github.com/TanStack/query/blob/f56fc8415904d79a4658167e01a8dbbcf842bd8f/packages/query-core/src/queryClient.ts#L357
Aims to solve: #6
I tried to mimic the behavior but using
queryCache
.Ps: The idea behind this PR is to start a discussion about if it's viable to prefetch in this way or not.