feat(warnings): Suggest casting boolean keys

Closes vuejs#6126
posva · Jul 17, 2017 · 0f7f8d9 · 0f7f8d9
1 parent ac3d1ea
commit 0f7f8d9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/shared/util.js b/src/shared/util.js
@@ -22,7 +22,7 @@ export function isFalse (v: any): boolean %checks {
  * Check if value is primitive
  */
 export function isPrimitive (value: any): boolean %checks {
-  return typeof value === 'string' || typeof value === 'number'
+  return typeof value === 'string' || typeof value === 'number' || typeof value === 'boolean'
 }
 
 /**

diff --git a/test/unit/modules/vdom/create-element.spec.js b/test/unit/modules/vdom/create-element.spec.js
@@ -162,6 +162,15 @@ describe('create-element', () => {
     expect('Avoid using non-primitive value as key').toHaveBeenWarned()
   })
 
+  it('doesn\'t warn boolean key', () => {
+    new Vue({
+      render (h) {
+        return h('div', { key: true })
+      }
+    }).$mount()
+    expect('Avoid using non-primitive value as key').not.toHaveBeenWarned()
+  })
+
   it('nested child elements should be updated correctly', done => {
     const vm = new Vue({
       data: { n: 1 },