Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove linux thumbnailing #185

Merged
merged 1 commit into from
Nov 20, 2024
Merged

remove linux thumbnailing #185

merged 1 commit into from
Nov 20, 2024

Conversation

ravener
Copy link
Contributor

@ravener ravener commented Nov 18, 2024

This removes the logic where osu! tries to thumbnail itself, I have a few reasons for this and also this is urgent after #181 was merged which changed osu!.png to osu.png I missed this one, so before we end up with a broken release let's settle this.

Thumbnailing is usually the job of the file manager and whatever thumbnailing plugins it has, so this doesn't look like a good idea

  • for one it only thumbnails after launching the game, otherwise it won't have the icon
  • it also made me a bit confused in regards to AppImage is missing the icon in file managers osu#30759 where the user's file manager thumbnailing was failing due to an entirely different issue, which also made me aware kde can thumbnail appimages for example, so this is not our job.

@peppy peppy merged commit 9005f33 into ppy:master Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants