Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BASSloud libraries #6233

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

smallketchup82
Copy link

@smallketchup82 smallketchup82 commented Apr 4, 2024

Prerequisite for ppy/osu#27793 and #6281
Would be wise to wait for peppy/ManagedBass#1 to get merged before reviewing this

This PR adds BASSloud libraries to osu-framework.

The only issue I've found with this PR is that osu! might not open on arm windows due to bassloud not being found, as there's no arm version for bassloud.

As usual, you'll have to make a new version of ppy.Framework.NativeLibs upon merging

@smoogipoo smoogipoo self-requested a review April 5, 2024 08:00
@smallketchup82 smallketchup82 changed the title Update BASS libraries and add BASSLoud & BassEnc Update BASS libraries and add BASSLoud Apr 17, 2024
@smallketchup82
Copy link
Author

Marking this PR as a draft for now since I plan on rebasing it on top of #6352

Will likely force push the previous diffs away.

@smallketchup82 smallketchup82 marked this pull request as draft August 19, 2024 01:06
@smallketchup82
Copy link
Author

I've rebased the branch on top of master and cleaned up history a bit.

Here's a full changelog:

  • Since master now has the latest bass libs, updating them here is no longer needed. I'll change the title and description to match this. It should probably make reviewing this PR a lot easier as now we're only adding new libs
  • I've also taken to noting that osu-framework logs the version of bass and its addons on startup. I've added BASSloud to this
  • As frenzibyte pointed out to me a while back, this PR doesn't actually add the libraries for mobile platforms. This is now fixed

For anyone that has this branch cloned locally, I'd recommend fetching and resetting to the remote branch head. Or delete and check out this branch again. I've confirmed with most that I know that have this branch cloned and made sure they do not have any local changes.

@smallketchup82 smallketchup82 changed the title Update BASS libraries and add BASSLoud Add BASSloud libraries Oct 16, 2024
@smallketchup82 smallketchup82 marked this pull request as ready for review October 16, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant