osu!(lazer) not importing old beatmaps correctly

[GaticoYuca]

Type

Crash to desktop

Bug description

osu!(lazer) does not import the flair of very old maps (2010 - 2011) and thus even when downloading directly for the in-game beatmap listings, maps with the "ranked" flair on the listings are imported without any flair and those maps also don't award any ranked stats because the game thinks they are unranked

Screenshots or videos

this video show a map being downloaded directly through the in-game listings

2024-11-17-20-14-17.1.mp4

Version

lazer 2024.1115.3

Logs

compressed-logs.zip

[bdach]

I can't reproduce this, and logs contain the following:

2024-11-18 00:15:05 [verbose]: [?????] Beginning import from tmpkikfbf.osz...
2024-11-18 00:15:06 [verbose]: [f3168] Found existing beatmap for Hatsune Miku - Senbonzakura (Short Ver.) (NatsumeRin) (ID e2fa765b-3780-4d0a-a396-2bd62b6c3190) – skipping import.

What I'm thinking is that the existing import is wrong and keeps getting restored.

Can you try the following?

1. Go to one of the broken maps
2. Delete it
3. Close the game and open it again
4. Redownload the map

Does doing that fix the issue?

Additionally, do you recall if you've originally imported the beatmap from stable or something?

---

On one side, the following check probably should be a lot smarter:

osu/osu.Game/Beatmaps/BeatmapImporter.cs

Lines 275 to 285 in 28fb0bf

	protected override bool CanReuseExisting(BeatmapSetInfo existing, BeatmapSetInfo import)
	{
	if (!base.CanReuseExisting(existing, import))
	return false;
	var existingIds = existing.Beatmaps.Select(b => b.OnlineID).Order();
	var importIds = import.Beatmaps.Select(b => b.OnlineID).Order();
	// force re-import if we are not in a sane state.
	return existing.OnlineID == import.OnlineID && existingIds.SequenceEqual(importIds);
	}

but on the other, making it so will likely significantly slow bulk imports, so...