Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat channels listing is not ordered by most recent activity #30835

Open
peppy opened this issue Nov 22, 2024 · 4 comments
Open

Chat channels listing is not ordered by most recent activity #30835

peppy opened this issue Nov 22, 2024 · 4 comments
Assignees

Comments

@peppy
Copy link
Member

peppy commented Nov 22, 2024

It should be, on initial load and when new messages come in.

We already have last_message_id in osu_chat.channels, so it may be quite feasible to make this happen without too much stress.

Of note, it should also be returned in this order by the API if possible.

Discussed in #18461

Originally posted by respektive May 28, 2022
On osu-web the direct messages are order by recent activity (newer DMs are at the top), while in lazer it's seemingly random.

Direct messages order on web:
osu-web
vs. order in lazer:
lazer

This isn't really an issue when you only have a few DMs open like I do in the screenshots, but the more chats you open the harder it gets to keep track of which chats are actually relevant.

@peppy peppy transferred this issue from ppy/osu Nov 22, 2024
@nanaya
Copy link

nanaya commented Nov 22, 2024

channels are currently sorted differently by type (last message id for pm and alphabetically for the rest) so osu-web just sort them on the frontend when doing the grouping.

@peppy
Copy link
Member Author

peppy commented Nov 22, 2024

So is the correct resolution here for lazer to do it client side?

@nanaya
Copy link

nanaya commented Nov 22, 2024

yeah, unless we're changing the order to be by last message id for all channel types.

even then it seems still easier to have sorting on frontend as new message comes in. it'd save the need to modify the channel array without it ending up just being a full on sort.

@peppy peppy self-assigned this Nov 22, 2024
@peppy
Copy link
Member Author

peppy commented Nov 22, 2024

Okay thanks, moving back to other repo.

@peppy peppy transferred this issue from ppy/osu-web Nov 22, 2024
peppy added a commit to peppy/osu that referenced this issue Nov 22, 2024
- Public channels (and announcements) are now alphabetically ordered.
- Private message channels are now ordered by most recent activity.

Closes ppy#30835.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants