Basic tl-tapping consideration for stamina #20558

vunyunt · 2022-10-03T06:41:59Z

Prereqs:

Populate beatmap ruleset in SoloScoreInfo.ToScoreInfo() #20984

The main aim of this PR is to improve difficulty calculation for patterns with extremely fast and long mono patterns. In this case, the player can use more than 2 fingers to press the same keys (known as tl-tapping), making the original assumption of 2 fingers available for each colour false.

Difficulty Calculator Changes:

Refactored colour slightly to allow access to colour data in all notes instead of just the first note of each pattern chunk. The detection of first note is moved into colour evaluator.
Implemented variable available finger count for stamina. Mono notes more than 300ms away from a colour change is considered to have an available finger count of 4.
Removed convert specific nerfs in difficulty calculation.
Reduced the minimum note interval for stamina to an unrealistically small value (1ms). This is now only to prevent division by zero or negative values.

Performance Calculator Changes:

Introduction of a rulesetTaiko bool, which applies previous bonuses strictly to the taiko ruleset as a way to combat easy-to-memorise converts. This is temporary until the reading skill is implemented.
The HDFL bonus to accuracy has been changed to be able to give 0 bonus, and an increase cap to 1.1x. This was in response to issues discovered within very short maps paired with HDFL giving the same bonus as those with 1000 objects.

SR/PP spreadsheets:

With converts: https://docs.google.com/spreadsheets/d/1eS4BBq7Ku7oY62nHtOnRBbrnhSTiMphLiHpwyWwEcwA/edit#gid=686072955

Without converts: https://docs.google.com/spreadsheets/d/12tejBO5JFGvOfuAKnayHHcWv5MWxOfH591eT6Vhk0h4/edit

As of 9065cb0

…tColour

Lawtrohux

looks fine to me. in the future when more skills are worked on we can hope that converts and their respective playstyles don't continue to need special consideration.

…t/osu into stamina-available-fingers

Lawtrohux · 2022-10-03T09:40:09Z

@smoogipoo can we get a smoogisheet for this build with converts enabled please?

smoogipoo · 2022-10-04T04:17:15Z

SR/PP sheet added to the description.

Lawtrohux

reapproving as smoogisheet was just to double check unseen values.

what i will say is that some loved converts gain absolute stupid sr, but this solely due to them being impossible maps in the first place, however this issue is past this fix/buff/nerf to things so ill leave that up to discretion having a significant amount of 10* - 40* converts.

smoogipoo · 2022-10-05T11:06:46Z

So just to confirm, it's intended that https://osu.ppy.sh/scores/taiko/151614379 gains 300pp and becomes the new pp record?

Lawtrohux · 2022-10-07T05:06:09Z

So just to confirm, it's intended that https://osu.ppy.sh/scores/taiko/151614379 gains 300pp and becomes the new pp record?

In regards to other scores gaining, this is justified. Converts were previously fixed nerfed 20% by the nature of the code, and are in a better place now then before. While tweaks still need to be made, this is planned for the next large pr within the coming week containing the rewrite of the rhythm skill.

smoogipoo · 2022-10-07T10:57:44Z

osu.Game.Rulesets.Taiko/Difficulty/Evaluators/StaminaEvaluator.cs

+        private static int availableFingersFor(TaikoDifficultyHitObject hitObject)
+        {
+            DifficultyHitObject? previousColourChange = hitObject.Colour.PreviousColourChange;
+            DifficultyHitObject? nextColourChange = hitObject.Colour.NextColourChange;
+
+            if (previousColourChange != null && hitObject.StartTime - previousColourChange.StartTime < 300)
+            {
+                return 2;
+            }
+
+            if (nextColourChange != null && nextColourChange.StartTime - hitObject.StartTime < 300)
+            {
+                return 2;
+            }
+
+            return 4;
+        }


Why is it 2 or 4 fingers, instead of 1 or 2 fingers?

mechanically, normal taiko players have 2 fingers available to hit each colour, with the TL playstyle, they use four and above fingers solely to hit the single colour.

2 fingers refers to the normal count, while 4 refers to the new count if the threshold is reached.

smoogipoo · 2022-10-07T11:02:32Z

osu.Game.Rulesets.Taiko/Difficulty/Preprocessing/Colour/TaikoColourDifficultyPreprocessor.cs

+                        foreach (var hitObject in monoStreak.HitObjects)
+                        {
+                            hitObject.Colour.MonoStreak = monoStreak;
+                        }


Isn't it functionally equivalent to add:

hitObject.Colour.AlternatingMonoPattern = monoPattern; hitObject.Colour.RepeatingPattern = repeatingHitPattern;

In this loop? Just to reduce the amount of looping.

Yeah it should be, will apply this when I'm back

Applied in 122064d

mangomizer

Smoogisheet seems to feature mostly converts (which I agree is the main goal of this), and PR does a fair job in tackling this issue.

I would like to see the results for mode-specific maps (we should expect minimal changes) before making any call on this though (can't seem to find many in the smoogisheet).

smoogipoo · 2022-10-11T12:42:40Z

I would like to see the results for mode-specific maps

Added to OP.

smoogipoo · 2022-11-01T07:09:21Z

Updated the spreadsheets in the description because they were generated incorrectly (see ppy/osu-queue-score-statistics#102). Please re-check.

Lawtrohux

lgtm! the new values actually look better as per the accuracy issue

mangomizer

I believe I've raised in the past that it would be useful to run it through a sample of "known" maps as a benchmark, even if just to confirm that the change is minimal.

If I am right in assuming that maps not showing up is indicative of minimal change (ie. <0.1* SR), approved.

smoogipoo · 2022-11-01T09:31:33Z

If I am right in assuming that maps not showing up is indicative of minimal change (ie. <0.1* SR), approved.

Correct, it only shows SR differences >0.1*.

Lawtrohux · 2022-11-02T00:30:31Z

I'll just quickly state that while the comment in the detection of rulesets is indeed temporary in regards to specific multipliers. It is planned to be used in a couple of others ways in future PR's, meaning that the related PR's to assist with this are not for a temporary function.

smoogipoo · 2022-11-02T01:15:24Z

@peppy or @bdach give this one a once over please.

peppy · 2022-11-03T06:51:54Z

osu.Game.Rulesets.Taiko/Difficulty/TaikoPerformanceCalculator.cs

@@ -43,6 +43,9 @@ protected override PerformanceAttributes CreatePerformanceAttributes(ScoreInfo s
            if (totalSuccessfulHits > 0)
                effectiveMissCount = Math.Max(1.0, 1000.0 / totalSuccessfulHits) * countMiss;

+            // TODO: The detection of rulesets is temporary until the leftover old skills have been reworked.
+            bool taikoSpecificBeatmap = score.BeatmapInfo.Ruleset.OnlineID == 1;


Would it be better to call this isConvert similar to everywhere else?

That's a fair point.

peppy

Seems fine code-wise

vunyunt and others added 9 commits September 29, 2022 15:27

Refactor to move first-object detection to evaluation

d84c956

Implement mono tl nerf for stamina, disable convert specific nerfs

09a38fe

Refactor previous and next colour change into TaikoDifficultyHitObjec…

02092ed

…tColour

Apply nerfs to HD/FL bonuses with converts

e6093f9

reintroduce fl bonus to converts

a276e40

decrease finger count

4b562f7

xml, remove speedbonus cap

6752655

Correct xmldoc

c933b62

Correct xmldocs

25976e1

pull-request-size bot added the size/L label Oct 3, 2022

peppy added ruleset/osu!taiko area:difficulty labels Oct 3, 2022

remove idea plugin xml

7e578f8

Lawtrohux previously approved these changes Oct 3, 2022

View reviewed changes

vunyunt added 2 commits October 3, 2022 17:31

Fix code inspect issues and SR test cases

47781a8

Merge branch 'stamina-available-fingers' of https://github.com/vunyun…

16413fc

…t/osu into stamina-available-fingers

vunyunt dismissed Lawtrohux’s stale review via 16413fc October 3, 2022 09:32

smoogipoo requested a review from a team October 4, 2022 09:22

Lawtrohux previously approved these changes Oct 4, 2022

View reviewed changes

smoogipoo reviewed Oct 7, 2022

View reviewed changes

smoogipoo mentioned this pull request Oct 7, 2022

Port TL-tapping stamina changes ppy/osu-performance#175

Merged

2 tasks

mangomizer reviewed Oct 7, 2022

View reviewed changes

Minor refactoring to reduce amount of looping

122064d

vunyunt dismissed Lawtrohux’s stale review via 122064d October 8, 2022 23:09

smoogipoo requested a review from mangomizer October 11, 2022 12:42

Merge branch 'master' into stamina-available-fingers

4342521

smoogipoo dismissed mangomizer’s stale review via 4342521 October 28, 2022 04:07

This was referenced Oct 28, 2022

Populate beatmap ruleset in SoloScoreInfo.ToScoreInfo() #20984

Merged

Fix missing beatmap ruleset ppy/osu-queue-score-statistics#102

Merged

smoogipoo added 2 commits November 1, 2022 13:01

Merge branch 'master' into stamina-available-fingers

720d6b5

Merge branch 'master' into stamina-available-fingers

9065cb0

smoogipoo requested review from mangomizer and Lawtrohux November 1, 2022 07:09

Lawtrohux previously approved these changes Nov 1, 2022

View reviewed changes

mangomizer previously approved these changes Nov 1, 2022

View reviewed changes

smoogipoo previously approved these changes Nov 2, 2022

View reviewed changes

Rename var

5448c02

smoogipoo dismissed stale reviews from mangomizer, Lawtrohux, and themself via 5448c02 November 2, 2022 01:15

smoogipoo previously approved these changes Nov 2, 2022

View reviewed changes

peppy reviewed Nov 3, 2022

View reviewed changes

Rename to isConvert

819027d

smoogipoo dismissed their stale review via 819027d November 4, 2022 07:17

peppy approved these changes Nov 6, 2022

View reviewed changes

smoogipoo approved these changes Nov 7, 2022

View reviewed changes

smoogipoo merged commit a2b4e5b into ppy:master Nov 7, 2022

smoogipoo mentioned this pull request Nov 29, 2022

Update osu nuget packages ppy/osu-queue-score-statistics#106

Merged

vunyunt deleted the stamina-available-fingers branch January 22, 2024 00:01

smoogipoo mentioned this pull request Feb 6, 2024

Bump databased star rating versions #27065

Merged

smoogipoo mentioned this pull request Oct 30, 2024

Bring back convert nerf to fix overweighted taiko difficulty #30456

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Basic tl-tapping consideration for stamina #20558

Basic tl-tapping consideration for stamina #20558

vunyunt commented Oct 3, 2022 •

edited by smoogipoo

Loading

Lawtrohux left a comment

Lawtrohux commented Oct 3, 2022

smoogipoo commented Oct 4, 2022

Lawtrohux left a comment

smoogipoo commented Oct 5, 2022

Lawtrohux commented Oct 7, 2022

smoogipoo Oct 7, 2022

Lawtrohux Oct 7, 2022

smoogipoo Oct 7, 2022

vunyunt Oct 8, 2022

vunyunt Oct 8, 2022

mangomizer left a comment

smoogipoo commented Oct 11, 2022

smoogipoo commented Nov 1, 2022

Lawtrohux left a comment

mangomizer left a comment

smoogipoo commented Nov 1, 2022

Lawtrohux commented Nov 2, 2022

smoogipoo commented Nov 2, 2022

peppy Nov 3, 2022

smoogipoo Nov 4, 2022

peppy left a comment

Basic tl-tapping consideration for stamina #20558

Basic tl-tapping consideration for stamina #20558

Conversation

vunyunt commented Oct 3, 2022 • edited by smoogipoo Loading

Difficulty Calculator Changes:

Performance Calculator Changes:

Lawtrohux left a comment

Choose a reason for hiding this comment

Lawtrohux commented Oct 3, 2022

smoogipoo commented Oct 4, 2022

Lawtrohux left a comment

Choose a reason for hiding this comment

smoogipoo commented Oct 5, 2022

Lawtrohux commented Oct 7, 2022

smoogipoo Oct 7, 2022

Choose a reason for hiding this comment

Lawtrohux Oct 7, 2022

Choose a reason for hiding this comment

smoogipoo Oct 7, 2022

Choose a reason for hiding this comment

vunyunt Oct 8, 2022

Choose a reason for hiding this comment

vunyunt Oct 8, 2022

Choose a reason for hiding this comment

mangomizer left a comment

Choose a reason for hiding this comment

smoogipoo commented Oct 11, 2022

smoogipoo commented Nov 1, 2022

Lawtrohux left a comment

Choose a reason for hiding this comment

mangomizer left a comment

Choose a reason for hiding this comment

smoogipoo commented Nov 1, 2022

Lawtrohux commented Nov 2, 2022

smoogipoo commented Nov 2, 2022

peppy Nov 3, 2022

Choose a reason for hiding this comment

smoogipoo Nov 4, 2022

Choose a reason for hiding this comment

peppy left a comment

Choose a reason for hiding this comment

vunyunt commented Oct 3, 2022 •

edited by smoogipoo

Loading