Populate beatmap ruleset in SoloScoreInfo.ToScoreInfo()
#20984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
changed the title
SoloScoreInfo.ToScoreInfo()
This was referenced Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're to do "is converted beatmap" checks as per #20558, which I don't think is necessarily a bad idea, then the beatmaps' ruleset needs to be populated in the conversion from
SoloScoreInfotoScoreInfo.This will also require an osu-queue-score-statistics change to pass in the APIBeatmap, that I'll do as a followup if this PR is accepted/when a new nuget package is released.
I've done the bare minimum here by populating just the ruleset, but there are other members in
IBeatmapInfothat aren't passed across like BPM, Length, etc... Unfortunately, as far as I know, we don't have a function to convertIBeatmapInfo/APIBeatmapInfotoBeatmapInfo, so populating all members will require substantial effort. Please give me your opinions on this.