Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode toggle in the right-hand sidebar #44

Closed
ddelange opened this issue Nov 27, 2020 · 1 comment
Closed

Dark mode toggle in the right-hand sidebar #44

ddelange opened this issue Nov 27, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@ddelange
Copy link

Is your feature request related to a problem? Please describe.
Google Chrome (Mac OS X) respects system wide dark mode setting. However, the tab bar becomes barely readable for me when Chrome is in dark mode, so I disabled dark mode for Chrome.

Quoting furo docs on dark mode, it seems I won't be able do view dark furo projects without putting my whole browser in dark mode (unwanted):

Furo is in light mode by default, switching to the dark mode when requested by the user’s browser (through prefers-color-scheme: dark).

As a consequence of this design, the dark mode inherits the variable definitions from the light mode, only overriding specific values to adapt the theme. While the mechanism for switching between light/dark mode is not configurable, the exact CSS variable definitions used in this process can be configured.

Describe the solution you'd like
A nice solution would be to keep this behaviour, but to additionally give the user the option to override the CSS prop with a toggle, like for instance Docker docs have on every page.

Describe alternatives you've considered
Alternatively, I could somehow attempt hack my Chrome set up to emulate this CSS prop on all websites by default, essentially putting my Chrome in dark mode only for the content and not for Chrome's own UI.

Additional context
Docker docs example dark mode toggle on the right:
image

@ddelange ddelange added the enhancement New feature or request label Nov 27, 2020
@pradyunsg
Copy link
Owner

Same as #24. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants