Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow the flag useHostNameAsBookieID to be modified post deployment #169

Closed
SrishT opened this issue Sep 22, 2021 · 0 comments · Fixed by #170
Closed

Do not allow the flag useHostNameAsBookieID to be modified post deployment #169

SrishT opened this issue Sep 22, 2021 · 0 comments · Fixed by #170

Comments

@SrishT
Copy link
Contributor

SrishT commented Sep 22, 2021

Description

The value of the flag useHostNameAsBookieID is hardcoded to true at the time of deployment, however the users can modify its value post deployment by editing the bookkeeper cluster resource. This however would break upgrades (for pravega/bookkeeper versions < 0.10.0) due to a mismatch in the Bookie ID value stored in the cookies before and after the upgrade, and should therefore not be allowed.

Importance

nice

Location

pkg/apis/bookkeeper/v1alpha1/bookkeepercluster_types.go

Suggestions for an improvement

N.A.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant