Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-86] Pass Pravega credentials as environment variables for integration test #87

Closed
wants to merge 3 commits into from

Conversation

vijikarthi
Copy link
Contributor

Signed-off-by: Vijay Srinivasaraghavan [email protected]

Change log description

  • Fixed integration test to pass security credentials as environment variable

Purpose of the change
Fixes #86

What the code does
If the auth flag is enabled, then the test configuration will include the credential information as environment variable for the ClientConfig implementation to instantiate the default Credentials instance.

How to verify it
./gradlew clean build should pass

@vijikarthi vijikarthi requested review from ravisharda and fpj May 17, 2019 23:20
…gration test

  * Fixed integration test to pass security credentials as environment variable

Signed-off-by: Vijay Srinivasaraghavan <[email protected]>
@vijikarthi vijikarthi marked this pull request as ready for review May 21, 2019 16:39
…gration test

  * Fixed auth header typo

Signed-off-by: Vijay Srinivasaraghavan <[email protected]>
Copy link

@ravisharda ravisharda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@crazyzhou
Copy link
Contributor

Closing stale PR

@crazyzhou crazyzhou closed this Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass Pravega credentials as environment variables for integration test
3 participants