Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing alternate ways to do image version validation for non-production environments #394

Closed
SrishT opened this issue May 15, 2020 · 1 comment · Fixed by #423
Closed
Assignees
Labels
area/charts Issue related to Operator or Pravega Helm chart priority/P1 Recoverable error, functionality/performance impaired but not lost, no permanent damage

Comments

@SrishT
Copy link
Contributor

SrishT commented May 15, 2020

Description

Users should be allowed to specify whether the charts are being for development purposes or not. While deploying the operator for development purposes, the users should either be allowed to provide their own version map, or should be allowed to skip version validation altogether. This is required since currently there doesn't seem to be any other way to use the pravega charts (without modifying them) to deploy pravega versions that are not already part of the version map.

Importance

must have

Location

pravega helm charts

@SrishT SrishT added priority/P1 Recoverable error, functionality/performance impaired but not lost, no permanent damage area/charts Issue related to Operator or Pravega Helm chart labels May 15, 2020
@SrishT SrishT self-assigned this May 15, 2020
@pbelgundi
Copy link
Contributor

Pravega version validation can be made dynamic or skipped in the following ways:
(1) Dynamic version support- Existing helm chart should be modified so the map for "versions-config-map" template should be accepted in values.yaml file instead of being hard-coded.
(2) Skipping Version Validation - Operator supports a "webhook" flag (similar to the "test-mode" flag) which can be set to false to disable "version-validation". I would not recommend doing this for production environments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/charts Issue related to Operator or Pravega Helm chart priority/P1 Recoverable error, functionality/performance impaired but not lost, no permanent damage
Projects
None yet
2 participants