Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a values check for 1-BK deployments #587

Closed
nishant-yt opened this issue Oct 26, 2021 · 0 comments · Fixed by #598
Closed

Adding a values check for 1-BK deployments #587

nishant-yt opened this issue Oct 26, 2021 · 0 comments · Fixed by #598
Assignees

Comments

@nishant-yt
Copy link
Collaborator

nishant-yt commented Oct 26, 2021

Description

Verify whether the bookkeeper cluster has been deployed with one replica and if so , make sure the following condition is met bookkeeper.ensemble.size >= bookkeeper.write.quorum.size >= bookkeeper.ack.quorum.size

Importance

must-have

Location

https://github.com/pravega/pravega-operator/blob/master/pkg/apis/pravega/v1beta1/pravegacluster_types.go

Suggestions for an improvement

The following checks should be performed :

  1. bookkeeper.ensemble.size >= bookkeeper.write.quorum.size >= bookkeeper.ack.quorum.size
  2. If bookkeeper.ensemble.size == 1 then bookkeeper.write.quorum.racks.minimumCount.enable should be set to false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant