Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include change event type in watchChange calls #813

Closed
zakcutner opened this issue Aug 29, 2021 · 0 comments · Fixed by #814
Closed

Include change event type in watchChange calls #813

zakcutner opened this issue Aug 29, 2021 · 0 comments · Fixed by #814
Labels
bug Something isn't working

Comments

@zakcutner
Copy link

Thanks for fixing #811 so quickly! As a follow-up issue while trying to use the Windi CSS rollup plugin, I noticed that WMR doesn't pass through a change argument (like Rollup does) for watchChange calls. This causes the plugin to error since it is expecting to read this argument but it does not exist.

I cloned WMR and confirmed that simply adding { event: 'update' } to the watchChange call fixes this issue (WMR seems to only listen for update events in any case). However, I didn't want to make a PR in case it's also desired handle creation/deletion events like Rollup does? If so, I'm not sure how this would affect the other logic that runs on file system changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant