-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced Filtering: Selecting a filter chip should not clear the filter #543
Comments
@toshegg can we have things inside chips with own click events and without breaking things? |
I'm working on fixing this bug on our end and adding an enhancement to fire a separate event when the text in the chip is clicked (as opposed to the X icon) |
PRIORITY 2 (GE fixing px-chip) |
Need for Beta |
This is waiting for a fix from @talimarcus in px-chip, which is still waiting on a branch. |
Still waiting on webcomponents/shadydom#190 |
This issue or PR has been automatically marked as stale because there has been no activity in over a year. It will be closed in 1 week if no further activity occurs. Thanks for your contribution, and please don't hesitate to comment if this issue/PR is still relevant. |
Description
Per spec, selecting the "x" in the filter chip should remove the filter. The way it's implemented currently, the whole chip is selectable and will remove the filter on click.
This can be seen on the demo as well, so no test code provided.
Version
Data-grid: V1.1.6
Browser: Safari10,Chrome
Screenshot
The text was updated successfully, but these errors were encountered: