Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Filtering: Selecting a filter chip should not clear the filter #543

Closed
ppeyro opened this issue Jan 30, 2018 · 7 comments
Closed

Comments

@ppeyro
Copy link

ppeyro commented Jan 30, 2018

Description

Per spec, selecting the "x" in the filter chip should remove the filter. The way it's implemented currently, the whole chip is selectable and will remove the filter on click.
This can be seen on the demo as well, so no test code provided.

Version

Data-grid: V1.1.6
Browser: Safari10,Chrome

Screenshot

screen shot 2018-01-30 at 1 01 09 pm

@alump
Copy link
Contributor

alump commented Jan 30, 2018

@toshegg can we have things inside chips with own click events and without breaking things?

@talimarcus
Copy link

I'm working on fixing this bug on our end and adding an enhancement to fire a separate event when the text in the chip is clicked (as opposed to the X icon)

@Aileen-H
Copy link

PRIORITY 2 (GE fixing px-chip)

@andrealperry
Copy link

Need for Beta

@davidrleonard
Copy link
Contributor

This is waiting for a fix from @talimarcus in px-chip, which is still waiting on a branch.

@davidrleonard davidrleonard assigned talimarcus and unassigned alump Mar 2, 2018
@talimarcus
Copy link

Still waiting on webcomponents/shadydom#190

@stale
Copy link

stale bot commented Mar 2, 2019

This issue or PR has been automatically marked as stale because there has been no activity in over a year. It will be closed in 1 week if no further activity occurs. Thanks for your contribution, and please don't hesitate to comment if this issue/PR is still relevant.

@stale stale bot unassigned talimarcus Mar 2, 2019
@stale stale bot added the wontfix label Mar 2, 2019
@stale stale bot closed this as completed Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants