Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PEP 508 specific extensions #1214

Open
davidbrochart opened this issue Apr 17, 2024 · 4 comments
Open

Support PEP 508 specific extensions #1214

davidbrochart opened this issue Apr 17, 2024 · 4 comments
Labels
✨ enhancement Feature request

Comments

@davidbrochart
Copy link

Problem description

See #1186 (comment).

I cannot use pixi with jupyter-collaboration:

git clone https://github.com/jupyterlab/jupyter-collaboration.git
cd jupyter-collaboration
pixi init
  × failed to parse project manifest
    ╭─[pyproject.toml:11:16]
 10 │     requires-python = ">=3.8"
 11 │ ╭─▶ dependencies = [
 12 │ │       # jupyter-server extensions
 13 │ │       "jupyter-server-ydoc @ {root:uri}/projects/jupyter-server-ydoc",
 14 │ │       # jupyterlab/notebook frontend extensions
 15 │ │       "jupyter-collaboration-ui @ {root:uri}/projects/jupyter-collaboration-ui",
 16 │ │       "jupyter-docprovider @ {root:uri}/projects/jupyter-docprovider",
 17 │ │       # the metapackage
 18 │ │       "jupyter-collaboration @ {root:uri}/projects/jupyter-collaboration",
 19 │ ├─▶ ]
    · ╰──┤ relative path without a working directory: {root:uri}/projects/jupyter-server-ydoc
    ·    │ jupyter-server-ydoc @ {root:uri}/projects/jupyter-server-ydoc
    ·    │                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 20 │     dynamic = ["version"]
    ╰────
@davidbrochart davidbrochart added the ✨ enhancement Feature request label Apr 17, 2024
@olivier-lacroix
Copy link
Contributor

olivier-lacroix commented Apr 17, 2024

I think resolving this would require implementation in pixi’s dependency https://github.com/konstin/pep508_rs

would you consider opening an issue there?

@olivier-lacroix
Copy link
Contributor

Alternatively, I believe you should be able to use ${PROJECT_ROOT} in your paths, and they should be expanded correctly

@tdejager
Copy link
Contributor

@olivier-lacroix @davidbrochart pep508_rs allows for these extensions. https://github.com/PyO3/pyproject-toml-rs does not. But it would be kinda difficult because you would need to give the directory that path is relative to during deserialization.

@tdejager
Copy link
Contributor

Alternatively, I believe you should be able to use ${PROJECT_ROOT} in your paths, and they should be expanded correctly

This can only be used in an environment e.g using tasks or pixi shell. And its ${PROJECT_ROOT}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement Feature request
Projects
None yet
Development

No branches or pull requests

3 participants