Fix missing key case, add BC type checking #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilRunninger
requested changes
Jan 19, 2021
autoload/nerdtree/ui_glue.vim
Outdated
|
|
||
| if v:false is# s:validateType(l:customOpenArgs, v:t_dict) | ||
| if v:false is# s:validateType(l:customOpenArgs, type({})) || empty(l:customOpenArgs) |
There was a problem hiding this comment.
I don't know if anyone still uses it, but NERDTree is supposed to be compatible to 7.3. After reviewing (the 7.3 documentation](http://vimdoc.sourceforge.net/htmldoc/eval.html#expression-syntax), I think is# and v:false didn't exist at that time. Let's use this instead.
Suggested change
| if v:false is# s:validateType(l:customOpenArgs, type({})) || empty(l:customOpenArgs) | |
| if !s:validateType(l:customOpenArgs, type({})) || empty(l:customOpenArgs) |
autoload/nerdtree/ui_glue.vim
Outdated
| return l:defaultOpenArgs | ||
| endif | ||
|
|
||
| for l:typeKey in keys(l:defaultOpenArgs) | ||
| if v:false is# s:validateType(get(l:customOpenArgs, l:typeKey, {}), v:t_dict) | ||
| if v:false is# s:validateType(get(l:customOpenArgs, l:typeKey, {}), type({})) |
There was a problem hiding this comment.
Same here.
Suggested change
| if v:false is# s:validateType(get(l:customOpenArgs, l:typeKey, {}), type({})) | |
| if !s:validateType(get(l:customOpenArgs, l:typeKey, {}), type({})) |
And below...
function! s:validateType(variable, type) abort
return type(a:variable) == a:type
endfunction
PhilRunninger
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1205