-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose reporter api #41
feat: expose reporter api #41
Conversation
Ok, so I had a bit of time to think about this and I'm not sure this is a great approach. Besides, the lack of docs and testing – to make sure this doesn't change w/o breaking you – an API that takes reporter functions creates a larger surface area than necessary. What is now I'll put something together later today since it turns out I also kinda need this for a clang-format linter I'm working on. |
I think this package can be separated into three part ( maybe we can have something like this? function generateDifferences(source: string, target: string): Result[];
interface Result {
operation: Operation;
offset: number;
insertText: string;
deleteText: string;
}
enum Operation {
Insert,
Delete,
Replace,
} |
@zertosh @not-an-aardvark, is this PR okay or what should I do? |
I don't have anything constructive to add. |
Can we get this merged and publish? Thanks. 😅 |
Is there any schedule for the release including this PR? I'd love to see it happen. ❤️ |
Oops, I forgot to publish it. I'll do that now. |
Published as v2.2.0. |
Fixes #39