Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for language specific settings #386

Closed
medikoo opened this issue Mar 7, 2018 · 6 comments
Closed

No support for language specific settings #386

medikoo opened this issue Mar 7, 2018 · 6 comments
Labels
enhancement locked Please open a new issue and fill out the template instead of commenting.

Comments

@medikoo
Copy link

medikoo commented Mar 7, 2018

e.g. having in VS Code settings:

"[markdown]": {
  "prettier.tabWidth": 2
},

Is reported as Uknown editor configuration setting and indeed has no effect

@CiGit
Copy link
Member

CiGit commented Mar 8, 2018

VSCode only allows some settings in language settings. mostly editor. ... like editor.formatOnSave

Extensions are unaware of those settings when using Settings API.(Without re-implementing the logic)

@medikoo
Copy link
Author

medikoo commented Mar 8, 2018

@CiGit corresponding issue is here: microsoft/vscode#26707

Still, it's clear that extensions can support it, as it can be retrieved as:

workspace.getConfiguration().get('[markdown]')['prettier.tabWidth']

Are you trying to say that there's no plan to support that at this point

@CiGit
Copy link
Member

CiGit commented Mar 8, 2018

Thanks for the link.

workspace.getConfiguration().get('[markdown]')['prettier.tabWidth']

This is what I meant by re-implementing

I'm pretty convinced this should be implemented by VSCode.
We may have to annotate our settings tho. We already do that to support multiple workspace (scope: "resource")

We already have a mean to scope settings by language, prettier config files support that.
https://prettier.io/docs/en/configuration.html#configuration-overrides

@CiGit
Copy link
Member

CiGit commented Mar 8, 2018

Seems you use .editorconfig overrides should also work 😃

@medikoo
Copy link
Author

medikoo commented Mar 8, 2018

Seems you use .editorconfig overrides should also work

Sure, but I just wanted to address the prettier specificity, that for no code snippets it uses spaces instead of tabs (and then I would like to have it kept at 2).

Now it seems wrong to put it in editorconfig, as it's general (not just for prettier), and I don't want to force tabsWidth setting when project is indented with tabs (tabsWidth should be up to developer liking).

We already have a mean to scope settings by language, prettier config files support that.

If I can have config at home directory that will affect any project, then indeed it can be solution (otherwise I don't want to pollute every single project repo with that).
I'll check it, thanks

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked Please open a new issue and fill out the template instead of commenting. label Apr 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement locked Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

No branches or pull requests

2 participants