[v3] plugins declared in .prettierrc are not loaded on directory

[JounQin]

Environments:

• Prettier Version: 3.0.0
• Running Prettier via: CLI
• Runtime: v18.16.0
• Operating System: Linux
• Prettier plugins (if any): prettier-plugin-sh

Steps to reproduce:

un-ts/prettier#273 (comment)

Expected behavior:

Like prettier v2, .sh files should be checked

Actual behavior:

.sh files are not checked

---

After debugging, getSupportedFilesGlob here

prettier/src/cli/expand-patterns.js

Lines 130 to 145 in 79d8a39

	function getSupportedFilesGlob() {
	if (!supportedFilesGlob) {
	const extensions = context.languages.flatMap(
	(lang) => lang.extensions || [],
	);
	const filenames = context.languages.flatMap(
	(lang) => lang.filenames || [],
	);
	supportedFilesGlob = `**/{${[
	...extensions.map((ext) => "*" + (ext[0] === "." ? ext : "." + ext)),
	...filenames,
	]}}`;
	}
	return supportedFilesGlob;
	}
	}

does not resolve .sh files correctly.

[fisker]

It's a known issue, are you sure it works in v2?

[JounQin]

@fisker I tried @devcrev's reproduction at https://github.com/devcrev/p-sh-old, it works on v2.

> [email protected] format
> prettier --check .

Checking formatting...
[warn] level-0/go.sh
[warn] level-0/hello.sh
[warn] level-0/level-1/another.sh
[warn] level-0/level-1/library.js
[warn] level-0/level-1/runme.sh
[warn] level-0/program.js
[warn] Code style issues found in 6 files. Forgot to run Prettier?

[JounQin]

Could be related to Plugin search feature has been removed?

[tylervz]

I am having this same issue with the .xml files and .properties files in my project. I'm using plugin-xml version 3.1.0 and the latest commit of prettier-plugin-properties (npm install -D [email protected]:eemeli/prettier-plugin-properties.git#0c7072dae2006c0d0a588f70b19940390a50add1)

[Jeto143]

I've noticed that you now need to specify something like **/*.* (rather than a folder, such as .) to the CLI command in order to parse files that have been registered by a plugin declared in the prettier configuration file. This wasn't the case with 2.*. It might be related to #14759, as @JounQin pointed out.

Related issue I've opened in a plugin's repo (as I thought it no longer worked): shufo/prettier-plugin-blade#213

[devcrev]

The current documentation seems to indicate that the behavior should be as it was in version 2.

[devcrev]

This package.json script for v3 does what I want and what v2 did with prettier . --check:

"scripts": {
   "format": "prettier './**/*' --check --ignore-unknown"
 },

[dummdidumm]

I'm observing this bug, too. Running npx prettier --write . will ignore any .svelte files, running npx prettier --plugin prettier-plugin-svelte --write . works. My debugging so far lead my to believe that this issue is with the file glob. The file glob is created from the context that is created at the start of the CLI run. If I pass the plugin, the context contains the info that Svelte files are eligible for formatting so the file glob includes Svelte files, else it doesn't.

So the fix is either to adjust the context creation to also search for a .prettierrc starting from process.cwd() and load any plugins from there, or to widen the file glob to include all files, not just the ones the context says it knows about.

[thorn0]

@dummdidumm Indeed. Config files are resolved for each processed file, which is too late.

[sosukesuzuki]

I'll work on this

[sdellysse]

Just chiming in that I was just bit by this trying to get .sh files to be formatted with prettier-plugin-sh. I have to do prettier --plugin=prettier-plugin-sh . to get it working. I'm willing to take a stab at fixing this, but I have no knowledge of the codebase. Would anyone have any pointers as to where to start debugging this issue?

[sosukesuzuki]

@sdellysse I'm working on this, please wait. #15433