Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there is missing p-xl class that would be like p-col #20

Closed
godfryd opened this issue May 8, 2020 · 3 comments
Closed

there is missing p-xl class that would be like p-col #20

godfryd opened this issue May 8, 2020 · 3 comments

Comments

@godfryd
Copy link

godfryd commented May 8, 2020

I would like to use the following classes for my element: class="p-col-12 p-xl",so

  1. on mobile the element takes whole width
  2. but in case of desktop it takes proportional width with other elements in p-grid row.

It appears that p-xl, p-lg, p-md and p-sm are not defined.

@cagataycivici
Copy link
Member

I could not understand the use case, what should be the value of p-xl? Please elaborate #2.

@godfryd
Copy link
Author

godfryd commented Aug 27, 2020

Example: I have 7 elements in a row. In case of mobile each of them should take 100% width
so they are one below another (ie. one takes whole row actually).
In case of desktop I want to fit them in one row so each of them takes 1/7 of 100% width.
For that I would use p-col but this is for mobile only, for desktop I should use p-xl, p-lg, etc.
But they are not defined.

p-xl, p-lg, p-md, p-sm would be defined in similar way as p-col ie. with flex-grow: 1.

@cagataycivici
Copy link
Member

Should be fine with v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants