Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table: p-columnFilter missing aria-label #14272

Closed
TaneliTuomola opened this issue Dec 4, 2023 · 1 comment
Closed

Table: p-columnFilter missing aria-label #14272

TaneliTuomola opened this issue Dec 4, 2023 · 1 comment
Assignees
@cetincakiroglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.0.0

Comments

@TaneliTuomola
Copy link
Contributor

Describe the bug

WCAG 2.1: Button missing a text alternative. Provide a text alternative for the button p-columnFilter.

Add ariaLabel -property to the p-columnFilter component.

Environment

Windows, Chrome

Reproducer

https://primeng.org/table#filter

Angular version

17.0.0

PrimeNG version

17.0.0-rc.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.6.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@TaneliTuomola TaneliTuomola added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 4, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 6, 2023
@cetincakiroglu cetincakiroglu self-assigned this Dec 6, 2023
@cetincakiroglu cetincakiroglu added this to the 17.0.0 milestone Dec 6, 2023
@TaneliTuomola
Copy link
Contributor Author

The main ToggleButton (.p-column-filter-menu-button) still missing aria-label. Buttons inside filter menu (Apply & Clear) are ok now.

@TaneliTuomola TaneliTuomola mentioned this issue Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
2 participants
@cetincakiroglu @TaneliTuomola