Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p-treeTableCheckbox disabled not working #17496

Closed
4 tasks
stajne opened this issue Jan 24, 2025 · 0 comments · Fixed by #17495
Closed
4 tasks

p-treeTableCheckbox disabled not working #17496

stajne opened this issue Jan 24, 2025 · 0 comments · Fixed by #17495
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
19.0.6

Comments

@stajne
Copy link
Contributor

stajne commented Jan 24, 2025

Describe the bug

In primeng version 19 p-treeTableCheckbox has disabled property but it is not used in html of the component (comparing to previous version (16)). Hence checkbox is clickable even though disabled is true

Pull Request Link

#17495

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/4wyzxwda?file=src%2Fapp%2Ftree-table-selection-checkbox-demo.html

Environment

windows 11

Angular version

19

PrimeNG version

v19

Node version

22.13.0

Browser(s)

No response

Steps to reproduce the behavior

create a tree table with checkbo and set [disabled]="true"

Expected behavior

checkbox should be disabled
@stajne stajne added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 24, 2025
@stajne stajne mentioned this issue Jan 24, 2025
Merged
@mertsincan mertsincan linked a pull request Jan 29, 2025 that will close this issue
fix: p-treeTableCheckbox disabled not working #17495
Merged
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 29, 2025
@mertsincan mertsincan added this to the 19.0.6 milestone Jan 29, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 29, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeNG
Status: Done
Milestone
19.0.6
Development

Successfully merging a pull request may close this issue.

fix: p-treeTableCheckbox disabled not working stajne/primeng
2 participants
@stajne @mertsincan