Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover design token issue #17500

Open
2 of 4 tasks
tsapasMi33 opened this issue Jan 25, 2025 · 0 comments
Open
2 of 4 tasks

Popover design token issue #17500

tsapasMi33 opened this issue Jan 25, 2025 · 0 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@tsapasMi33
Copy link

tsapasMi33 commented Jan 25, 2025

Describe the bug

Hello!

I am having some issues with the popover element in the latest version

First of all, the arrow does not switch sides correctly. I saw that a PR is already under review so I will not be posting a fix to this. Please consider adding the fix in the next release :)

Otherwise, I am trying to use a design token for scoped theming, but it has no effect.

I managed to modify it's style through the define preset method, but a global style is not a great solution for our case.

Design tokens and extend components are great features so allow me to congratulate you on your work. It would be great though if we could have some more documentation and tutorials regarding these new features.

I am not providing a PR as I am not sure how to fix the issue but if you can direct me, I would be more than happy to contribute.

Thank you!!

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/~/github.com/tsapasMi33/primeng-issue-template

Environment

Windows 11,
(Not sure what to write here..

Angular version

19.1.4

PrimeNG version

v19

Node version

22.9.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Pass a design token to the component
  2. No visual effect

Expected behavior

The design token should modify the component in it's scope

@tsapasMi33 tsapasMi33 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

1 participant