Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer: loses sliding transition after exiting fullScreen mode #17504

Open
4 tasks
itismohammadreza opened this issue Jan 27, 2025 · 0 comments
Open
4 tasks
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@itismohammadreza
Copy link
Contributor

Describe the bug

When enabling the fullScreen mode for the drawer component at runtime, the component transitions correctly with the fullscreen behavior (using opacity). However, when fullScreen is set to false afterward, the component fails to return to its sliding transition. Instead, it retains the opacity-based transition used for the fullscreen mode, resulting in an inconsistent user experience.

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/cjwth51q?file=src%2Fapp%2Fimports.ts,src%2Fapp%2Fdrawer-basic-demo.html,src%2Fapp%2Fdrawer-basic-demo.ts

Environment

windows

Angular version

19

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. Render the drawer component with fullScreen set to false.
  2. Change the fullScreen property to true during runtime.
  3. Observe the fullscreen transition (opacity-based).
  4. Set the fullScreen property back to false.

Expected behavior

When exiting the fullscreen mode (fullScreen set to false), the drawer should seamlessly revert to the sliding transition.

@itismohammadreza itismohammadreza added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

1 participant